@MelvinAguilar
Posted
Hello there π. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
HTML π·οΈ:
- Wrap the page's whole main content in the
<main>
tag.
Alt text π·:
- The
alt
attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.
-
The
alt
attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a betteralt
attribute would beQR code to frontendmentor.io
If you want to learn more about the
alt
attribute, you can read this article. π.
CSS π¨:
- To center an element vertically, you should use a height to its container. In this case it is recommended to use "min-height: 100vh" so that it occupies 100% of the viewport height. Also, add
justify-content: center;
to its container. e.g.:
body {
background-color: var(--bg-color);
display: flex;
flex-direction: column;
align-items: center;
/* margin-top: 5rem; */
min-height: 100vh;
justify-content: center;
}
I hope you find it useful! π Above all, the solution you submitted is great!
Happy coding!
Marked as helpful