QR Code first task

Community feedback

• 

  Bishal Singh Deo🎮•1,440

  @Bishalsnghd07Posted 9 months ago

  Hi @grgrnkoo

  Congrats for completing this challenge 🎉 and Amazing work👏

  Yeah, box shadow is working well. Apart from that I, would recommend to work on little bit CSS part, as I see your code you have been used height in your body, never ever use that it will only break your layout, in small projects it is negligible, but when you work in larger project then this will give you a disaster result. Instead of height you can use min-height.

  Other that that good job and Happy Coding❤️

  Marked as helpful

  0

  ---

  

  grgrnkoo•520

  @grgrnkooPosted 9 months ago

  @Bishalsnghd07 thanks for the review! I think it's a first time in my practice when the page's content has less height than the page. Will use min-height in my following projects!

  I'm going to complete each free project on Frontend Mentor before diving into JavaScript, so I hope to see more of your reviews in the future

  Happy Coding and have a nice weekend <3

  1
• 

  Tahiat•60

  @Ayman-FaiyazPosted 9 months ago

  Woow! Your one is Perfect!

  0

  ---

  

  grgrnkoo•520

  @grgrnkooPosted 9 months ago

  @Ayman-Faiyaz thanks, my friend

  0