Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code First Solution using margin and padding

@Anteonallen

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

P
Will 310

@wansmth

Posted

Hi,

I'm not sure where I got the shadow on the QR code in all honesty lol. I put one on my solution but I think I meant to put it on the whole card itself. Looking at it now, there seems to be a subtle shadow at the bottom of the card, so it looks as if it is raised from the page slightly.

Either way, it's just one of these: https://developer.mozilla.org/en-US/docs/Web/CSS/box-shadow

If you Google 'css box shadow' there are websites which allow you to visually tweak a box shadow and then copy paste the css over.

Sorry for the confusion.

For the centring, I was doing this:

body { height: 100vh; display: flex; align-items: center; justify-content: center; }

Marked as helpful

0
P
Will 310

@wansmth

Posted

Looks good to me. If I had to nit-pick a few things:

  • Missing the shadow on the QR code image.
  • The card isn't vertically aligned with the page and so does not stay centred when you zoom out. Consider making the body element 100% of the viewport height and using flexbox to vertically align, rather than using top-margin as you have.

Marked as helpful

0

@Anteonallen

Posted

Hey Alan,

Thank you for your feedback, when you mentioned the shadow on the QR code image, do you have the command/coding example for it? Personally, I can't tell the difference between my design and its solution.

Also, for the body element 100% of the viewport height, is this the right command? body { height: 100%; }

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord