Francisco Carrillo• 5,540
@frank-itachi
Posted
Hello there 👋. You did a good job!
I have some suggestions about your code that might interest you.
HTML 📄:
- Wrap the page's whole main content in the
<main>tag. - If your code has different sections that have a specific like a , , sections or footer, it’s a good practice to enclose those parts with HTML5 landmarks.
For example, you could use a
<footer>tag to wrap a footer section. - The heading order is important in the html structure so try to always start your headings and/or titles with an
<h1>tag and then you can decrease by one if you need to use more headings in your html code.
CSS🎨:
You can use grid or flexbox to center the content no matter the viewport size. Since I use grid to achieve such purpose, you can do the following:
body {
min-height: 100vh;
display: grid;
align-items: center;
justify-content: center;
}
As I said, you can use flexbox to center the content and it will work as well.
body {
min-height: 100vh;
display: flex;
align-items: center;
justify-content: center;
}
I hope you find it useful! 😁😁 Above all, the solution you submitted is great👌!
Happy <coding /> 😎!
0
