QR Code

Community feedback

• 

  Jordan Bugglin•170

  @JbugglinPosted about 2 months ago

  When uploading your initial commit to GitHub, just copy/click and drag to the file area on screen the contents of your qr-code-component-main file. That might be the reason why nothing is appearing on the screen for your submission. Also, I would put the style.css file in the same folder as your index.html instead of in the design folder.

  Once I was able to open it (via cloning and opening in vs code), it looks good! The border around the qr-code image is a little bit thick, just an adjustment to the qr-code-container padding would do it.

  You may want to use the <main> and <footer> semantic HTML5 tags as well. I would use main as the main container instead of section. That way it'll be the main focal point of the website and helps out on the report. I included a quick link to the tags and how best to use them, you may have came across it, if not it's a good reference: https://www.w3schools.com/html/html5_semantic_elements.asp

  I would also adjust the QR-Description class, to the border-radius of 1rem instead of matching the qr-code's border-radius of 0.5rem. You'll have a consistent radius that will keep the appearance of the border around the image to be the same thickness.

  Overall, you did a great job, keep learning and good luck in future endeavors!

  0