Design comparison
Community feedback
- @NehalSahu8055Posted over 1 year ago
Hello Coder π.
Congratulations on successfully completing the challenge! π
Few suggestions regarding design.
- Replace
height:100vh
withmin-height:100vh
in the container for properly center the card.
body{ min-height: 100vh; }
-
For
non-decorative images
give meaningful and descriptive alt likealt= "QR code to frontend mentor website"
. -
Use
responsive units(rem, em, %)
from next project. Explore respective use cases on google.link. -
Replace
width
withmax-width
to make your card more responsive.
I hope you find this helpful.
Happy codingπ
Marked as helpful0 - Replace
- @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
BODY MEASUREMENTS π:
- Use
min-height: 100vh
forbody
instead ofheight: 100vh
. Setting theheight: 100vh
may result in the component being cut off on smaller screens, such as mobile devices in landscape orientation
- For example; if we set
height: 100vh
then thebody
will have100vh
height no matter what. Even if the content spans more than100vh
of viewport.
- But if we set
min-height: 100vh
then thebody
will start at100vh
, if the content pushes thebody
beyond100vh
it will continue growing. However if you have content that takes less than100vh
it will still take100vh
in space.
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord