P
visualdennis• 8,375
@visualdenniss
Posted
Hey Mariah,
your solution looks great. I have a suggestion regarding centering. To center your card, instead of paddings: 5%; a better practice would be min-height 100vh, so it stays more consistent with changing browser sizes. E.g.
main { display: grid; place-items: center or your flex-code and ; min-height: 100vh; }
also you can add some min-width to your code to prevent it getting too narrow with resizing.
Hope you find this feedback helpful!
Marked as helpful
1
Mariah Wear• 20
@mariahw4
Posted
@visualdenniss THANK YOU!! I updated the padding to vh and definitely see the benefit! Also added some min/max width elements so my box doesn't shrink down to such a hard to read size on a smaller window/mobile device!
1
