QR Code Desktop Design

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

• I have a suggestion regarding your code that I believe will be of great interest to you.

CSS 🎨:

• Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.

• We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

• To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

• For this demonstration we use css Grid to center the component.

body {
    min-height: 100vh;
    display: grid;
    place-items: center;
}

• Now remove these styles, after removing you can able to see the changes

div {
  margin-left: auto;
  margin-right: auto;
  margin-top: 0%;
}

• Now your component has been properly centered

• Another important point to note here is using % values for width & heights, it's not suggested you can use em or rem like relative units. For Example:

div {
   width: 20rem;
}

• You don't need to apply height for div, because it will automatically consume the height for its need.

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!