QR Code design using just HTML and CSS

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • To better identify the main content of you site you will want to encase your entire component inside a Main Element.

  • Reduce 📉 the width of you component to better match the FEM design.

  • The Alt Tag description for the QR image needs to be improved upon. Its needs to tell screen reader users what it is and where it will take them to when they scan it.

  • Change width to `max-width: 100% in your image to make it responsive.

  • Move the following properties to the Body Element (delete the width and change the height to min-height):

  .card {
      width: 100%;
      height: 100vh;
      display: flex;
      flex-direction: column;
      justify-content: center;
      align-items: center;
  }
  

  If you have any questions or need further clarification, let me know.

  Happy Coding! 👻🎃

  Marked as helpful

  1

  ---

  

  Ivan•50

  @shin-bot87Posted about 2 years ago

  @vcarames Hi there! Thanks a lot! It's been really helpfull your feedback. I usually get confuse cause i don't really know when exactly y have to use width or max width...the same with height, even with height i don't reach to understand why never goes fit down when i type "height: 100%;" however when i use "width:100%" it's fit the whole width. Anyway, thanks a lot my friend, i will still practising everyday.

  0