Design comparison
Solution retrospective
This is my first ever HTML/CSS project. Any feedback about HTML Tags and CSS styling is highly appreciated!
Would you use different units (text-size, padding etc.) or am I on the right track? Is there something Semantic HTML stuff that I'm missing ?
Community feedback
- @icaroMendes777Posted about 2 years ago
Bro, for your first page this code looks awesome.
if there is any room for improvement, maybe it would be the selectors. In a single page you can say img{width: ...} because you have only one single image. In a big website with many pages you have many different images with different sizes, so just give img{width: ...} wont work.
But also don't need to make an unique id for each image. You can put a class in the main div, lets say .qr_code, then you select ".qr_code img" for the image inside the div.
This can make things more scalable, but in general is pretty good already.
Marked as helpful0@patrick-selinPosted about 2 years ago@icaroMendes777
Bro, thank you so much for your valuable feedback. Thanks for the tip about selectors. I'm going to change my code immediately.
Have a great day!
Kind regards, Patrick
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord