I think I would move it
.attribution { font-size: 11px; text-align: center; } .attribution a { color: hsl(228, 45%, 44%); }
from the index.html file to stylesheet.css Everything else I think it's a good work. Good luck.
Marked as helpful
I' m a complete beginner and looking to improve my coding.
@YondaimeFlash
Posted
Hey, how are you? Loved the project!! Some tips would be to put the font-size in the body so you dont have to repeat yourself and keep the code clean. Also, for the HTML part you can instead of creating a div for the written area, just use h1 and p so you wouldnt have to use a few of the properties in the CSS part. I would also recomend use box-sizing: border-box and margin:0 so you dont have a problem scrolling down to your name in the footer. :) Cheers man, great work!! Would love some feedback back too :)
Marked as helpful
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord