qr code design using flex-box

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  BODY MEASUREMENTS 📐:

  • Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens, such as mobile devices in landscape orientation

  ---

  • For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.

  ---

  • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0

  ---

  

  raheem king•80

  @Raheem-kingPosted over 1 year ago

  @0xAbdulKhalid this was very helpful thank you

  0
• Account deleted

  Hello Coder😊

  Your solution is fantastic

  but I have a small suggestion for you regarding <h1> tags

  <h1> tag :

  It is mandatory to use a <h1> tag in your solution because <h1> tag is most important aspect in accessibility and it helps screen reader to navigate with your page in easy way

  And H1 tags also help Google to understand the structure of a page. So if you're using H1s as Google recommends for your page title or content heading, your H1 is effectively telling Google “here's what my page is about.

  And one page only have one tittle so that's why just use one <h1> in your solution

  And you also can check my solution that will definitely going to help you

  Hope that will be helpful 😊

  0

  ---

  

  raheem king•80

  @Raheem-kingPosted over 1 year ago

  @MrSandipSharma thank you so much for the advice it was really helpful . Can u also check my product review card would love ur advice on it

  0