Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

qr code design using flex-box

raheem kingβ€’ 80

@Raheem-king

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

made use of grid and flex-box

What challenges did you encounter, and how did you overcome them?

No challenges

What specific areas of your project would you like help with?

none

Community feedback

Abdul Khaliq πŸš€β€’ 72,660

@0xabdulkhaliq

Posted

Hello there πŸ‘‹. Congratulations on successfully completing the challenge! πŸŽ‰

  • I have other recommendations regarding your code that I believe will be of great interest to you.

BODY MEASUREMENTS πŸ“:

  • Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens, such as mobile devices in landscape orientation
  • For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.
  • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

.

I hope you find this helpful πŸ˜„ Above all, the solution you submitted is great !

Happy coding!

0

raheem kingβ€’ 80

@Raheem-king

Posted

@0xAbdulKhalid this was very helpful thank you

0

Account Deleted

Hello Coder😊

Your solution is fantastic

but I have a small suggestion for you regarding <h1> tags

<h1> tag :

It is mandatory to use a <h1> tag in your solution because <h1> tag is most important aspect in accessibility and it helps screen reader to navigate with your page in easy way

And H1 tags also help Google to understand the structure of a page. So if you're using H1s as Google recommends for your page title or content heading, your H1 is effectively telling Google β€œhere's what my page is about.

And one page only have one tittle so that's why just use one <h1> in your solution

And you also can check my solution that will definitely going to help you

Hope that will be helpful 😊

0

raheem kingβ€’ 80

@Raheem-king

Posted

@MrSandipSharma thank you so much for the advice it was really helpful . Can u also check my product review card would love ur advice on it

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord