Qr code design using css and html

Community feedback

• Account deleted

  Hi chr1swil! Congratulations on your first challenge and hard work.

  I'm Alberto and I have some suggestions about your HTML code that might interest you:

  1 - The <div class="card"> tag could be between the <main> and </main> tags, so that search engines and screen readers could identify the main content of the page.

  2 - The <div class="attribution"> tag could be replaced by <footer class="attribution">, so that search engines and screen readers could identify the main footer of the page.

  3 - And the footer content could be wrapped between the <p> and </p> tag, for semantic reasons.

  4 - You could specify your Github URL in the <a> tag that surrounds your full name, in the main footer of the page, because the specified URL cannot be found.

  So those are my suggestions, I sincerely hope they help you improve your solution, chr1swil. If you have any doubt, question, or problem, know that I and other members of the platform would be happy to help you.

  Marked as helpful

  0

  ---

  

  chr1swill•30

  @chr1swillPosted over 1 year ago

  hey @Alberto-RJ, Thanks for your advice. Those changes didn't even cross my mind. I will definitely make those iterations to better my code.

  0

  Account deleted

  You're welcome @chr1swill. Congratulations on your great decision and I wish you a good job!

  0