QR Code Design implementation using HTML and CSS

Community feedback

• 

  P

  Øystein Håberg•10,710

  @Islandstone89Posted 2 days ago

  Hi Timi, well done!

  Here is some feedback :)

  HTML:

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" content. Change .main-container to a <main>.

  • I would change the heading to a <h2> - a page should only have one <h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.

  CSS:

  • Including a CSS Reset at the top is good practice.

  • It's common to set font-family on the body, and let its children inherit the value. Also, remember to specify a fallback font: font-family: 'Outfit',sans-serif;

  • I recommend adding a bit of padding, for example 16px, on the body, to ensure the card doesn't touch the edges on small screens.

  • I would move the styles on .main-container to the body.

  • On the body, change height to min-height: 100svh - this way, the content will not get cut off if it grows beneath the viewport.

  • Remove all widths and heights in px. We rarely want to give a component a fixed size, as we need it to grow and shrink according to the screen size.

  • We do want to limit the width of the card, so it doesn't get too wide on larger screens. To solve this issue, give the card a max-width of around 20rem.

  • letter-spacing should not be in px. You can use em, where 1em equals the element's font size.

  • Paragraphs have a default value of font-weight: 400, so there is no need to declare it.

  • On the image, add display: block, height: auto and max-width: 100% - the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container. max-width: 100% makes the image shrink to fit inside its container.

  Marked as helpful

  0

  ---

  

  Timi Gubernu•20

  @timilica29Posted 1 day ago

  @Islandstone89 Thank you so much for the feedback! Will definitely come back and update with these suggestions!

  1
• 

  WajahatAli130•10

  @WajahatAli130Posted 2 days ago

  Excellent! Looks just like the guide

  0