Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code design challenge

William Rozarioβ€’ 70

@William73920

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


CSS flexbox and fitting image in a proper div

Community feedback

Travolgi πŸ•β€’ 31,420

@denielden

Posted

Hello William, You have done a good work! 😁

Some little tips to improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • add descriptive text in the alt attribute of the images
  • use h1 for the title of card instead of a div
  • instead of using px use relative units of measurement like rem -> read here

Keep learning how to code with your amazing solutions to challenges.

Hope this help πŸ˜‰ and Happy coding!

Marked as helpful

0

William Rozarioβ€’ 70

@William73920

Posted

@denielden hey thanks for the tips I'll make sure to make the changes

1
Travolgi πŸ•β€’ 31,420

@denielden

Posted

@William73920 You are welcome and keep it up :)

0

@VCarames

Posted

Hey there! πŸ‘‹ Here are some suggestions to help improve your code:

  • To not only improve your HTML code but to also identify the main content of you page, you will want to wrap your entire component inside the main element.

More Info:πŸ“š

MDN Main Element

  • Change width to max-width in your component’s container to make it responsive.
  • The alt tag description for the β€œQR image” needs to be improved upon. Its needs to tell screen reader users what it is and where it will take them to when they scan it.
  • The "Improve your front-end skill by building projects" is a heading in this component, so should be wrapped in an heading element.

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding!πŸŽ„πŸŽ

Marked as helpful

0

William Rozarioβ€’ 70

@William73920

Posted

@vcarames thanks for ur suggestions ☺️

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord