@MelvinAguilar
Posted
Hello there 👋. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
HTML 📄:
- Wrap the page's whole main content in the
<main>tag.
Alt text 📷:
-
The
altattribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a betteraltattribute would beQR code to frontendmentor.ioIf you want to learn more about the
altattribute, you can read this article. 📘.
CSS 🎨:
-
Setting the font-size to 62.5% can attract compatibility issues with third-party libraries or plugins. You can read more about this with this lectures:
- 1. Should I change the default HTML font-size to 62.5%?.
- 2. The Surprising Truth About Pixels and Accessibility - The 62.5% trick.
- 3. A comment on the 62.5% trick
Credit to grace-snow and vanzasetia.
-
Use
min-height: 100vhinstead ofheight: 100vh. Theheightproperty can cause your component to be cut off on small screens, such as a mobile phone in landscape mode.
I hope you find it useful! 😄 Above all, the solution you submitted is great!
Happy coding!
Marked as helpful
@ogulcanyavuz00
Posted
@MelvinAguilar Thank you for your review, there are many things I didn't know about your points. I'll better them the next time. A special thanks for the reading materials. I'll make sure to read them.
