Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code design

@elsayedelbauomy

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

im proud of frontend monetor experince that it delever

What challenges did you encounter, and how did you overcome them?

i get to qr code and its really fun

What specific areas of your project would you like help with?

i wold get good step by step for css

Community feedback

@DanijelAdrinek

Posted

the size of your card is not the same as the size of the design, you didnt add any box-shadow, the image is too big, the font-size of the text is too big, and also in px instead of rem, we usually use rem because that allows users to choose how big the text on our page will be trough their browser settings.

usually in frontend development, you will have to see the size of the design, lower the size of your screen to that size, and take a screenshot (ctrl + shift + s), and compare it to the design in figma, and make sure it matches the design in every way, I believe here you have the perfect training ground for a task like that, and you get to show off your work to potential employers, so I suggest you start learning to do that, in css you didnt use any css variables, and sure, they arnt too useful on projects this small, but in bigger projects, they are a real life-saver.

div with a class of box should be a tag of main to help the screen readers, the container shouldnt be the size of height:100vh; you dont even need the container, just add height: 100%; to body and html tags, and center the card in the body tag.

anyway, still a good little project, I enjoyed going trough all the little things to try to help, if you want, here is how I finished the project, I hope you get to use it to learn from it and become a better web developer: https://www.frontendmentor.io/solutions/just-css-and-html-its-too-small-of-a-project-to-need-ro-add-anything-Lo9rFod9_5

if you got any questions you wish to ask, feel free to reach out, I'm always here to help :)

Hope you found this comment helpful, and happy coding friend :D

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord