Skip to content
Submitted 2 months ago

QR Code Design

Bshy201•80
@Bshy201
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I can up with the design rather quickly, but next time I would change how I structure my code.

What challenges did you encounter, and how did you overcome them?

The biggest problem I had was centering the container in the middle of pages. I looked at articles to help me with this.

Community feedback

  • Steven Stroud•11,910
    @StroudyPosted 2 months ago

    Amazing job with this! You’re making fantastic progress. Here are some small tweaks that might take your solution to the next level…

    • Using position: absolute is not always best practice because it removes elements from the normal document flow, making layouts harder to manage and potentially causing overlap or misalignment on different screen sizes. Instead, use flexible layout techniques like CSS Grid or Flexbox for more responsive and maintainable designs.

    • Using margin-inline: auto is better than margin: auto for centering elements horizontally because it is more precise.

    • To center an element, set its width and apply margin-inline: auto; this will center it within its container., You can center the height by using this code snippet, Add this to your body

      min-height: 100svh;
  display: flex;
  justify-content: center;
  flex-direction: column;
    • Then remove this from your .container, to center your QR without position: absolute
    position: absolute; */
    /* top: 20%; */
    /* left: 0; */
    /* right: 0; */
    /* bottom: 20%;

    • This does not matter that much at this stage but something to be mindful of for SEO(Search Engine Optimisation), <meta> description tag missing that helps search engine determine what the page is about, Something like this <meta name="description" content="description goes here" />

    • Using a <main> tag inside the <body> of your HTML is a best practice because it clearly identifies the main content of your page. This helps with accessibility and improves how search engines understand your content.

    • Using max-width: 100% or min-width: 100% is more responsive than just width: 100% because they allow elements to adjust better to different screen sizes. To learn more, check out this article: responsive-meaning.

    • Developers should avoid using pixels (px) because they are a fixed size and don't scale well on different devices. Instead, use rem or em, which are relative units that adjust based on user settings, making your design more flexible, responsive, and accessible. For more information check out this, Why font-size must NEVER be in pixels or this video by Kevin Powell CSS em and rem explained.- Another great resource for px to rem converter.

    You’re doing fantastic! I hope these tips help you as you continue your coding journey. Stay curious and keep experimenting—every challenge is an opportunity to learn. Have fun, and keep coding with confidence! 🌟

    Marked as helpful
    1
    Bshy201•80
    @Bshy201Posted 2 months ago

    @Stroudy Thanks for the feedback, I've already implemented your suggestions into my code.

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord