@Stroudy
Posted
Amazing job with this! You’re making fantastic progress. Here are some small tweaks that might take your solution to the next level…
-
Using
position: absoluteis not always best practice because it removes elements from the normal document flow, making layouts harder to manage and potentially causing overlap or misalignment on different screen sizes. Instead, use flexible layout techniques like CSS Grid or Flexbox for more responsive and maintainable designs. -
Using
margin-inline: autois better thanmargin: autofor centering elements horizontally because it is more precise. -
To center an element, set its width and apply
margin-inline: auto; this will center it within its container., You can center the height by using this code snippet, Add this to yourbody
min-height: 100svh;
display: flex;
justify-content: center;
flex-direction: column;
- Then remove this from your
.container, to center your QR withoutposition: absolute
position: absolute; */
/* top: 20%; */
/* left: 0; */
/* right: 0; */
/* bottom: 20%;
-
This does not matter that much at this stage but something to be mindful of for SEO(Search Engine Optimisation),
<meta>description tag missing that helps search engine determine what the page is about, Something like this<meta name="description" content="description goes here" /> -
Using a
<main>tag inside the<body>of your HTML is a best practice because it clearly identifies the main content of your page. This helps with accessibility and improves how search engines understand your content. -
Using
max-width: 100%ormin-width: 100%is more responsive than justwidth: 100%because they allow elements to adjust better to different screen sizes. To learn more, check out this article: responsive-meaning. -
Developers should avoid using pixels (
px) because they are a fixed size and don't scale well on different devices. Instead, useremorem, which are relative units that adjust based on user settings, making your design more flexible, responsive, and accessible. For more information check out this, Why font-size must NEVER be in pixels or this video by Kevin Powell CSS em and rem explained.- Another great resource for px to rem converter.
You’re doing fantastic! I hope these tips help you as you continue your coding journey. Stay curious and keep experimenting—every challenge is an opportunity to learn. Have fun, and keep coding with confidence! 🌟
Marked as helpful
@Bshy201
Posted
@Stroudy Thanks for the feedback, I've already implemented your suggestions into my code.
