Design comparison
Solution retrospective
How do you think I can improve my code?
Community feedback
- @vanzasetiaPosted 12 months ago
Hi Jean! π
Congratulations on finishing this challenge! π
I recommend removing all the
<div>
elements. You do not need to wrap every element with a<div>
. For example, you can make the<img>
as a block element (display: block
) and setmax-width: 100%
to prevent the image from overflowing.For the alternative text, I recommend telling "what the image is". In this case, it is a QR code that will redirect the users to frontendmentor.io. Also, you do not need to write the word "image" on the alternative text. Users will already know that it is an image. I recommend reading Quick tip: Using alt text properly - The A11Y Project.
I hope this helps. Happy coding! π
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord