@PhoenixDev22
Posted
Hi Julian Livrone,
Congratulation on completing this frontend mentor challenge. Your solution looks great. I have some suggestions regarding your solution:
- You should use
<main>
landmark to wrap the card. HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology.
- In my opinion, the image is an important content. The alternate text is needed on this image. The alternate text should indicate where the Qr code navigate the user : like
QR code to frontend mentor
not describes the image. The alternate text should not be hyphenated, it should be human readable.
- Add
min-height: 100vh
instead ofheight: 100vh
to the body that let the body grows taller if the content outgrows the visible page instead.
Aside these, Excellent work! Hopefully this feedback helps.
Marked as helpful
@JulianLivrone
Posted
@PhoenixDev22
Hello PhoenixDev22, thank you for taking the time to review my solution to this challenge.
I learned a lot thanks to your feedback, I have just uploaded the solution with the changes and fixes. Keep the good work, you teached me a lot!
Greetings.
@PhoenixDev22
Posted
@JulianLivrone Glad to help. Happy coding!