Skip to content
Submitted almost 2 years ago

QR Code CSS HTML

Noneco01•50
@Noneco01
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Hassia Issah•50,650
    @HassiaiPosted almost 2 years ago

    Add a language attribute to the html tag <html lang = "en">, replace <div class="bg"> with the main tag and <h6> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html

    There is no need to give .bg position: relative and its properties, width and height values.

    To center .scale on the page using flexbox, add min-height:100vh to .bg.

    There is no need for a height value in #box-1.

    Give h1 and p the same font-size of 15px which id 0.9375rem, text-align: center, the same margin-left, margin-right and margin-top values. Give p a margin bottom value.

    This challenge does not require a box-shadow.

    Use relative units like rem or em as unit for the padding, margin and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

    Hope am helpful.

    Well done for completing this challenge. HAPPY CODING

    Marked as helpful
    0
    Noneco01•50
    @Noneco01Posted almost 2 years ago

    @Hassiai Hey, thanks for reviewing my work! I would be glad to hear any suggestions and feedbacks from you that can help me improve my work!

    0
  • Alex Garcia 🦝 Garcialexco•440
    @garcialexcoPosted almost 2 years ago

    Hello! Great job completing your first challenge! 🔥

    There's a couple parts of your code that I might be able to help with:

    Make sure to use semantic HTML, here's an article in the subject.

    Link your fonts in the HTML head, it makes your page load just a bit faster.

    Try to use classes instead of ID's wherever possible, ID's are reserved for when you are using JS to manipulate an element. Classes are ideal for styling because you are able to reuse them throughout your code.

    Hope this helps, great job again on your first solution and keep up the great work! 👍 Happy Coding!

    Marked as helpful
    0
    Noneco01•50
    @Noneco01Posted almost 2 years ago

    @garcialexco Thanks you can that help me improve my work !

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord