Skip to content
Submitted about 2 years ago

QR code css and html

Harry Lee•40
@BestNerd
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I found this okay. I found the sizing a little strange, which may have been because I was using flex box, but none the less was not too bad. My github website does not seem to include the actual image of the QR however when I run it in VS code looks almost identical.

Community feedback

  • Adriano•38,330
    @AdrianoEscarabotePosted about 2 years ago

    Hi Harry Lee, how are you?

    I really liked the result of your project, but I have some tips that I think you will like:

    1- Every page should have one main landmark <main>. So replace the div that wraps the whole content with <main> to improve the accessibility. click here

    2- All page content should be contained by landmarks, you can understand better by clicking here: click here

    We have to make sure that all content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

    Example:

    native HTML5 reference elements:

    <body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>

    ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:

    <body>
     <div role="banner">This is the header</div>
     <div role="navigation">This is the nav</div>
     <div role="main">This is the main</div>
     <div role="contentinfo">This is the footer</div>
</body>

    It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.

    Link to read more about: click here

    2- Why it Matters

    Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.

    HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.

    Rule Description

    It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.

    Link to read more about: click here

    Prefer to use rem over px to have your page working better across browsers and resizing the elements properly

    The rest is great!!

    Hope it helps...👍

    Marked as helpful
    0
    Harry Lee•40
    @BestNerdPosted about 2 years ago

    @AdrianoEscarabote ah thank you for your advice will make sure to include that in my next project.

    Best - harry

    1
  • Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    👾Hi @BestNerd, congratulations on your first solution!👋 Welcome to the Frontend Mentor Coding Community!

    Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

    Something I've noticed in your code is that on many occasions you've added some <div> to wrap contents that don't really need to be inside of a div block. Note that for this challenge all you need is a single block to hold all the content, which can be <div> or <main> if you want to use a semantic tag to wrap the content, the cleanest structure for this challenge is made by a block of content with div/main and all the content inside of it (img, h1 and p) without need of any other div or something. See the structure below:

    <body>
<main>
<img src="./images/image-qr-code.png" alt="QR Code Frontend Mentor" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    0
  • Kawsar Ahmed Fahad•2,660
    @faha1999Posted about 2 years ago

    Hello, Harry Lee Congratulations on finishing this project. It's lovely and great on the whole! Just a little tip:

    • You might want to use semantic tags like the <main> to wrap your code, instead of div. like
    <main class="container"></main>
<footer class="attribution"></footer>

    This would help improve accessibility.

    • Fixed the img src.
    <img src="./images/image-qr-code.png" alt="qr-code">
    • add the below code to the body. It will center everything
    body {
    justify-content: center;
    align-items: center;
    display: flex;
    min-height: 100vh;
    flex-direction: column;
}

    • use modern CSS reset https://piccalil.li/blog/a-modern-css-reset/

    • remove the blow styles from .container-2

    .container-2{
    /* margin: 0 auto; */
    /* margin-top: 25rem; */
    /* margin-bottom: 25rem; */
}

    • Instead of using px, use relative units like rem or em to get better performance when the information on your page needs to be resized for multiple screens and devices. REM and EM apply to all sizes, not just font-size. You can code your entire page in px and then, at the very end, use the VsCode plugin px to rem to perform the automatic conversion px to rem

    • This is my solution for this project live, repo

    I hope it will work. Happy coding.

    Marked as helpful
    0
  • cesar hernan ruscica•320
    @hernanruscicaPosted about 2 years ago

    Hi Harry Lee, i was seeing your solution for this challenge. The first thing i would like to say is that you should check the link to the QR code, because it doesn't load. About the code, you should choose better name classes, with more meaning. I would like to see it working with the QR code, to see the sizes, but overall is done. Grettings.

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord