Skip to content
Submitted about 2 years ago

QR Code Component

Johan Carlos Santana•70
@johansantana
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Husam Asaad•420
    @husamasaadPosted about 2 years ago

    Really Amazing work my Friend, I love how you use relative Units perfectly.

    my advice to you is to put the your html code inside of a <main> tag and put the display: flex and height properties in the main tag instead of the body, and think about adding a box-shadow to your div it will look great and more perfect than it already is

    I hope my comment is helpful to you and happy coding journey >>

    Marked as helpful
    1
    Johan Carlos Santana•70
    @johansantanaPosted about 2 years ago

    @husamasaad thanks for the feedback!

    0
  • バレンタイン 😈•64,170
    @VCaramesPosted about 2 years ago

    Hey @johansantana, some suggestions to improve you code:

    • To give you HTML code structure, you want to set up your code in the following manner (only did parent containers):
      <body>
    <main>
      <article class="card-container”>
      </article>
    </main>
  </body>

    The Main Element identifies the main content of the document.

    While the Article Element will serve as the card’s container, because the card represents a complete, or self-contained, section of content that is, in principle, independently reusable.

    More info:

    https://web.dev/learn/html/headings-and-sections/

    • The Alt Tag description for the QR image needs to be improved upon. Its needs to tell screen reader users what it is and where it will take them to when they scan it.

    • To make your image fully responsive, you want to add max-width: 100%; to it.

    Happy Coding! 👻🎃

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord