QR Code Componet

Community feedback

• 

  farahsamsi•20

  @farahsamsiPosted 4 months ago

  Overall this looks very solid. Except the title text font weight and color. And the div container for the image is unnecessary. This code can simply be replaced by the following:

  • CSS: img { width: 100%; max-width: 256px; margin-top: 10px; }
  • HTML: <img src="images/image-qr-code.png" alt="">

  But other than that, the project looks very, very similar.

  Great job!

  0

  ---

  

  FATMA•300

  @Fatma-MPosted 4 months ago

  @farahsamsi Thanks for your feedback :) Isn't it better to separate the code into divs, from a semantic perspective I mean? So they all will be at the same level after all.

  0