Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Componet

FATMA 300

@Fatma-M

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@farahsamsi

Posted

Overall this looks very solid. Except the title text font weight and color. And the div container for the image is unnecessary. This code can simply be replaced by the following:

  • CSS: img { width: 100%; max-width: 256px; margin-top: 10px; }
  • HTML: <img src="images/image-qr-code.png" alt="">

But other than that, the project looks very, very similar.

Great job!

0

FATMA 300

@Fatma-M

Posted

@farahsamsi Thanks for your feedback :) Isn't it better to separate the code into divs, from a semantic perspective I mean? So they all will be at the same level after all.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord