QR Code Componet

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 10 months ago

  Hello @DevK-Eire!

  Your solution looks excelent!

  I have just one suggestion:

  • In order to make your HTML code more semantic, use <h1> for the main title instead of <p>. The tag <p> is meant for paragraphs, like you correctly did on the text Scan the QR code to visit Frontend Mentor and take your coding skills to the next level. For titles, though, we have the HTML Headings, the tags <h1> to <h6>.

  And here's a quick guide on how to use them:

  Unlike what most people think, it's not just about the size and weight of the text.

  📌 The <h1> to <h6> tags are used to define HTML headings.

  📌 <h1> defines the most important heading.

  📌 <h6> defines the least important heading.

  📌 Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

  This change has little or not effect at all on the project, but it makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, you did a great job!

  Marked as helpful

  0

  ---

  

  P

  Dev Killian•100

  @DevK-EirePosted 10 months ago

  @danielmrz-dev

  Thanks so much for the advice, I will keep that in mind :)

  0
• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted 10 months ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  • The <div> tag can be useful for styling and positioning, but it doesn't convey any semantic meaning. Instead, consider using more semantic elements like <p> to better describe the type of content. e.g.: <p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>.

  • Don't use a height in the text; it will cause it to overflow, and that's why there is no space between the two paragraphs of your solution

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  0

  ---

  

  P

  Dev Killian•100

  @DevK-EirePosted 10 months ago

  @MelvinAguilar thanks so much for your feedback. I have added <p> :)

  0