QR Code Components - Using Sass

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted about 2 years ago

  Hi @Rubendvb 👋, good job for completing this challenge! 🎉

  This is a good solution for this challenge and here are some suggestions you might consider:

  The container is not center. You can use flexbox to center things,

  body {
    . . .
    width: 100%;
    min-height: 100vh;
    display: flex;
    flex-direction: column;
    justify-content: center;
    align-items: center;
  }
  
  .main-container {
    max-width: 20rem;
    margin-block: 1rem
    . . .
  
    /* @include mixins.desktop-view; Remove this because with flexbox the element will already be centered */
  }
  

  I hope those tips will help you.

  Good Job and happy coding !

  Marked as helpful

  2

  ---

  

  P

  Ruben Vásquez•450

  @RubendvbPosted about 2 years ago

  @MelvinAguilar Hello Melvin. Thanks for the sugestion. I will implement it now.

  1