QR Code Components

Community feedback

• 

  Agata Liberska•3,995

  @AgataLiberskaPosted almost 3 years ago

  Hi Mohamed, nice work :) Awesome that you remembered to include you landmark elements :)

  However, it would be a good idea for you to really consider why you're applying certain styles. For example, you've set your body to display: flex; but you're not actually taking advantage of this - in fact, it actually messes things up a bit - when I open your solution, the card is stuck to the left of the screen - because of that display: flex property. You've also set a blue background on all elements, which you then had to override on your content container - it would've been a lot simpler to set the blue background on the body and white background on the card. Setting the height property on your card is also quite unnecessary - and again, it does mess things up on some larger mobile viewports where the white card is tiny and all content is overflowing it. Let the content take up the space that it needs, and space it out with some padding.

  Hope this helps, happy coding :)

  Marked as helpful

  0

  ---

  

  Mohamed El-Khalil Beneddra•60

  @khalilbndPosted almost 3 years ago

  @AgataLiberska Thank u so much, for the "flex" content i did remember that i fix it cause obviousely i knew that i can't let it on the left of course, and also now i know that i did override all content of the page with root selector, i appreciate your help

  0