@DigitaleWeltLibrary
Posted
Hey, good soluten but i have some points for improvment.
- Firstly i want to center the card in the middle of the screen. Therefore i use
grid
. Then i have to to say that every element in the grid container should be centered verticaly and horicontaly. Normaly every adult container has the height of all the children. We want the full theefore we useheight
(you can usemin-height
) too. 100dvh is the full height of the screen without the searchbar.
body{
display: grid;
place-items: center;
height: 100dvh;
}
- The card: The
grid
centered the card in the middle of the screen, therefore we didn`t need themargin
anymore. Never declare theheight
, because when the headline or the paragraf is longer the content overlaps.* Instead of usingpx
use themin function
. It means when the screen is widther than350px
thewidth
is equale to350px
. When it´s no widther than350px
it´s96dvw
of the screen width. (Themin function
makes it easier to make websites responsive. 😉)
.back{
/* width: 300px; */
/* height: 450px; */
/* margin: auto; */
padding: 10px;
width: min(90dvw, 350px);
}
- The img: As i said before never use px. The best choose is to use % as i used in the CSS. Then use
aspect-ratio
to make thewidth
and theheight
the same. And again it´s responsive 😉.
img {
border-radius: 20px;
/* width: 280px; */
/* height: 280px; */
aspect-ratio: 1 / 1;
width: 90%;
}
- You didn´t need the
div
with theimg
in it. This is how I would set it up
<section>
<img src="PATH" alt="TEXT" >
<h1>TEXT</h1>
<p>TEXT</p>
</section>
Maybe it helps you to see my solution of the challenge.😁
I hope i could help you. Happy coding 😊
Marked as helpful
@Codevkreate
Posted
Wow thanks a lot I would definitely look into this to improve the code 😊@DigitaleWeltLibrary Edit: So I tried what you recommended and it tells good but I don't know much about the min function so I'll go learn more about it and improve the code