QR code components

Hello there 👋. Good job on completing the challenge !

I have some suggestions about your code that might interest you.

HTML 🏷️:

• Wrap the page's whole main content in the <main> tag.

• Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute. The alt attribute should explain its purpose. e.g. QR code to frontendmentor.io

CSS 🎨:

• To center the content horizontally, use justify-content: center; to the body. Also, you can remove the margin: 0 auto; in the .container selector.

I hope you find it useful! 😄 Above all, the solution you submitted is great!

Happy coding!

Replace <div class="container"> with the main tag and <h2> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html

Give the alt attribute in the img tag a value. The value of the alt attribute is the description of the image. For decorative images like icons, there is no need to give it an alt value, for more on alt attribute Click here.

The body has a wrong background-color. Use the colors and font-family that were given in the styleguide.md found in the zip folder you downloaded

increase the padding vale of .image to 16px. and give the img a max-width of 100% instead of a width.

Give .text a margin value for all the sides, text-align: center and a font-size of 15px which is 0.9375rem, this will be the font-size of both p and h1.

Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

Hope am helpful.

Well done for completing this challenge. HAPPY CODING