QR Code componente using display flex

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello 👋. Congratulation on successfully completing your first challenge 🎉 ! !

  I have some recommendations regarding your code that I believe will be of great interest to you.

  Note: Sorry for not writing the comments in your native language :(

  HTML 📄:

  • Use semantic elements such as <main> and <footer> to improve accessibility and organization of your page.

  • The text Scan the QR code to visit Frontend Mentor and take your coding skills to the next level is considered a simple paragraph <p> and not a h2.

  CSS 🎨:

  • Use min-height: 95vh instead of height: 95vh. The height property can cause your component to be cut off on small screens, such as a mobile phone in landscape mode.

    screenshot-imgur (landscape mode)📸

  • The width: 100vw property in the .container tag is not necessary. This will create a horizontal scrollbar on some devices.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  0