QR Code Component Zyruks

Community feedback

• 

  Karol Binkowski•1,640

  @GrzywNPosted over 2 years ago

  Well done 🙌!

  As you said, it's an easy challenge. I kinda don't understand using empty files for SCSS, since this is really simple challenge and there is no need for that complex architecture, but of course it's your choice. I can suggest adding better responsiveness / scalability of the card for extra large screens for example 4K. Right now it's really small and hard to read. It can be done by using font-size property with clamp() CSS function. More on that here and here

  Great job once again and have a nice day and happy coding too ! 😁

  Marked as helpful

  1

  ---

  

  Samuel Llibre Santos•400

  @ZyruksPosted over 2 years ago

  @GrzywN Thanks ;)

  I check your solution and added new stuff to mine ;) With the scss files I'm trying to improve my personal SCSS implementation thats why i got more files but thanks for the suggestion.

  About the clamp I know how it work but im not sure how to make it work for 4k or so.

  Again thanks ;)

  1