Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Component

@iremozturkk3

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

David Oncu 350

@david-oncu

Posted

Congratulations on your solution:

Few suggestions to fix accessibility issues:

<div class="main-container"> <img src="images/image-qr-code.png" alt="qr-code-pic"> <h2>Improve your front-end skills by building projects</h2> <p> Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p> </div>

: change div to main :

<main class="main-container"> <img src="images/image-qr-code.png" alt="qr-code-pic"> <h2>Improve your front-end skills by building projects</h2> <p> Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p> </main> <div class="attribution"> Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>. Coded by <a href="#">Your Name Here</a>. </div>

change div to footer

<footer class="attribution"> Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>. Coded by <a href="#">Your Name Here</a>. </footer>

Overall great solution!

Marked as helpful

0

@iremozturkk3

Posted

@david-oncu thank u for your suggestions :)

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord