QR Code Component

Community feedback

• 

  David Oncu•350

  @david-oncuPosted over 2 years ago

  Congratulations on your solution:

  Few suggestions to fix accessibility issues:

  <div class="main-container"> <img src="images/image-qr-code.png" alt="qr-code-pic"> <h2>Improve your front-end skills by building projects</h2> <p> Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p> </div>

  : change div to main :

  <main class="main-container"> <img src="images/image-qr-code.png" alt="qr-code-pic"> <h2>Improve your front-end skills by building projects</h2> <p> Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p> </main> <div class="attribution"> Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>. Coded by <a href="#">Your Name Here</a>. </div>

  change div to footer

  <footer class="attribution"> Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>. Coded by <a href="#">Your Name Here</a>. </footer>

  Overall great solution!

  Marked as helpful

  0

  ---

  

  iremozturk•10

  @iremozturkk3Posted over 2 years ago

  @david-oncu thank u for your suggestions :)

  1