QR code component

Community feedback

• 

  Andre Ferreira•450

  @Namonaki0Posted over 1 year ago

  Nice job! Just a little trick for when you need to center the main component in the middle of the page.

  Since it's being rendered in the root you can style it like this:

  display: grid;

  height: 100vh;

  place-content: center;

  Hope it helps.

  Marked as helpful

  3

  ---

  

  Huy Hoang Le•70

  @b1tjPosted over 1 year ago

  @Namonaki0 you just give me new way to center a item, thanks a lot <3

  1
• 

  Jordan Martin•190

  @JordanMartinWebDevPosted over 1 year ago

  I think you got the card down pretty well, but you could move the attribution information at the bottom outside of the card since it wasn't a part of the challenge itself. Just take it out of your card div and put it right above your </body> tag. The original html doc included some CSS in it for the attribution section, so you should just have to move the html, assuming you didn't delete it.

  Marked as helpful

  0
• 

  Akintola Garuba•170

  @AkinGabsPosted over 1 year ago

  Very nice work. But you could have centered your card.

  2

  ---

  

  Huy Hoang Le•70

  @b1tjPosted over 1 year ago

  @AkinGabs fixed! thank you <3

  0

  

  Boots 😺•1,590

  @adityaphasuPosted over 1 year ago

  @b1tj omg hu tao spotted! fellow genshin player?

  0

  

  Huy Hoang Le•70

  @b1tjPosted over 1 year ago

  @adityaphasu yea :)

  1