Design comparison
Solution retrospective
just practicing, I'm new to this! xD
Community feedback
- @DrMESAZIMPosted over 2 years ago
Hi Jose
Since you are new to this I should start by say well done. I would like you to consider the size of the image which is relatively high. This can be easily done by adjusting the Height properties with the class of "qr-code".
If you find it difficult to resolve let me on and I can do YouTube video editing your code.
Marked as helpful1 - @Mod8124Posted over 2 years ago
Eso pa, el primer tico que me encuentro xD
Mae nunca use medidas fijas como pixeles es malo para el responsive, use mejor porcentajes y max width para que se adapten a la pantalla del dispositivo(aplica también al height) . Por ejemplo
.main-content { width: 616px; } //malo . main-content { Width :90% auto; max-width:616px; } //bueno
Ahh también te recomiendo aprender de una semántica de html ya q va comenzando para q agarré costumbre de encerar todo el contenido del html en
main
ya q ayuda al seo y accesibilidad ese es un ejemplo hay más tagsMarked as helpful0@kin9koopaPosted over 2 years ago@Mod8124 pura vida, solo tengo 2 semanas con HTML y CSS. vi un tutorial en youtube y con ese me guie para hacer este otro. pero si me falta mucha practica! gracias por los tips!
0 - @behubjPosted over 2 years ago
Hey Jose, very well done! I can relate to your comment, but i would suggest you give some time to your projects as i can see in your project the height of the main content is too big .
I am also in learning stage, but I highly recommend taking your time to understand what exactly the code does (Note:-Google is your best friend).
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord