QR Code Component

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  To center .card on the page using flexbox, replace the height in the body with min-height: 100vh.

  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  1

  ---

  

  P

  Andrea Y Costas•190

  @a-costasPosted over 1 year ago

  @Hassiai Thank you! That video you linked was very helpful. I have made the changes you suggested.

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  BODY MEASUREMENTS 📐:

  • Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.

  ---

  • For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh.

  ---

  • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  P

  Andrea Y Costas•190

  @a-costasPosted over 1 year ago

  @0xAbdulKhalid Thank you for the explanation, it helped contextualize the difference very well, I have changed it accordingly. Thanks again!

  0