Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

qr-code-component-main-solution

@Abelo73

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Hassia Issah 50,670

@Hassiai

Posted

Add the alt attribute alt=" " to the img tag and replace <div class="card"> with the main and <h3> with <h1> to fix the accessibility issue. click here for more on web-accessibility and semantic html

To center .card on the page using flexbox, replace the height with min-height: 100vh. there is no need for the height value, the padding value is a responsive replacement of that.

For a responsive content which won't require a media query for, this challenge, replace the width of .card with a max-width. e.g: max-width: 400px. Give p and h1 the same padding-left and padding-right values.

Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on CSS units Click here

Hope am helpful.

Well done for completing this challenge. HAPPY CODING

Marked as helpful

0

@Abelo73

Posted

@Hassiai Thank you for your amazing feedback. I'm glad to hear from you thanks a lot!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord