QR code component

Community feedback

• 

  P

  Øystein Håberg•10,390

  @Islandstone89Posted 9 months ago

  HTML:

  • Remove the <picture> element - it is used when you need to "offer alternative versions of an image for different display/device scenarios.".

  • The alt text must also say where it leads(frontendmentor.io).

  CSS:

  • It's good practice to include a CSS Reset at the top.

  • Add around 1rem of padding on the body, so the card doesn't touch the edges on small screens.

  • Remove the margin on the card. To center the card horizontally and vertically, add the following on the body:

  align-items: center;
  min-height: 100svh;
  

  • On the card, remove flex-direction: column(it only applies when using display: flex) and align-items: center(you don't need it - place-items: center takes care of the centering).

  • Remove all widths and heights in px and %.

  • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

  • font-size must never be in px. This is bad for accessibility, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • font-family only needs to be declared once, on the body.

  • On the image, add display: block and max-width: 100% - the max-width prevents it from overflowing its container.

  Marked as helpful

  1

  ---

  

  yoy•100

  @yoyfordPosted 9 months ago

  @Islandstone89

  thank u so much for reviewing my codes.I will notes this

  1