@AhmedMahrouss
Posted
good jop my bro Congrats on completing your challenge!ππ»If you have any questions or need further clarification, feel free to reach out to me. Happy Coding! ππ
Marked as helpful
@AhmedMahrouss
Posted
good jop my bro Congrats on completing your challenge!ππ»If you have any questions or need further clarification, feel free to reach out to me. Happy Coding! ππ
Marked as helpful
@MelvinAguilar
Posted
Hello there π. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
The Github repository is private or not available. :(
HTML π:
<main>
tag to wrap all the main content of the page instead of the <div>
tag. With this semantic element you can improve the accessibility of your page.CSS π¨:
h-screen
instead of h-[100vh]
.Using h-[100vh]
(height: 100vh
) to center the element can cause problems with the layout of the page on smaller screens, such as in landscape view on a mobile device.
On smaller screens, such as in landscape view on a mobile device, the height of the viewport may be less than the height of the content of the page. In this case, using h-screen
will cause the content of the page to be hidden behind the body element.
Here is an image of how it would look on a mobile device (taking into account the scroll): screencapture-mby-mini-netlify-app
To avoid this problem, it is generally recommended to use min-h-screen
(min-height: 100vh
) instead of h-[100vh]
. This will ensure that the content of the page is always visible.
I hope you find it useful! π Above all, the solution you submitted is great!
Happy coding!
Marked as helpful
@BawerMY
Posted
@MelvinAguilar thank you Melvin
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord