Melvin Aguilar 🧑🏻💻• 61,220
@MelvinAguilar
Posted
Hi there 👋. Good job on completing the challenge ! I have some feedback for you if you want to improve your code.
HTML:
- Use the
<footer>tag to wrap the footer of the page instead of the<div class="attribution">. The<footer>element contains information about the author of the page, the copyright, and other legal information.
- The
altattribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a betteraltattribute would beQR code to frontendmentor.io
If you want to learn more about the alt attribute, you can read this article.
- Instead of using pixels in font-size (
*{font-size: 15px;}), use relative units likeemorrem. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here.
I hope you find it useful! 😄 Above all, the solution you submitted is great!
Happy coding!
Marked as helpful
0
