@PhoenixDev22
Posted
Hi Diego,
Congratulation on completing your first challenge here in frontend mentor. Your solution looks great. I have some suggestions regarding your solution:
- The alternate text should indicate where the Qr code navigate the user : like
QR code to frontend mentor
not describes the image.
- Consider using
min-height: 100vh
instead ofheight: 100vh
to the body , that let the body grows taller if the content of the page outgrows the visible page.
- It's recommended to include a git ignore. This came with your starter files. It's less important in this challenge but will become extremely important as you move onto larger projects with build steps.
- There are a lot the arguments against the 62.5% font size trick ,it state that you should never change the root font size because it harms accessibility.
Overall, Excellent work! Hopefully this feedback helps.
Marked as helpful