QR-code-component

Community feedback

• 

  P

  Øystein Håberg•10,710

  @Islandstone89Posted 3 months ago

  HTML:

  • The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

  • .attribution should be a <footer>, and you should use <p> for the text inside.

  CSS:

  • Including a CSS Reset at the top is good practice.

  • I would recommend adding 1rem of padding on the body, to ensure the card doesn't touch the edges on small screens.

  • I usually set font-family on the body instead of :root.

  • I would move the properties on main to body, this way you can center both the main and the footer. Add flex-direction: column and gap: 2rem and change height to min-height - this way, the content will not get cut off if it grows beneath the viewport. Also, remove width: 100% - a block element like body takes up the full width by default.

  • It's recommended to use px instead of % for border-radius.

  • Well done for giving the card a suitable max-width, so it doesn't stretch indefinitely. However, it's best practice to use rem, so change it to max-width: 20rem.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • letter-spacing must also never be in px. You can use em, where 1em equals the element's font size.

  • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value. NB: text-align: center doesn't apply to images.

  • On the image, add display: block and change width to max-width: 100% - the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container. max-width: 100% makes the image shrink to fit inside its container.

  Marked as helpful

  1
• 

  Andrew Ezeani•370

  @ezeaniiandrewPosted 3 months ago

  Hi, congratulations on completing this challenge. You did a terrific job on it. A little tip that could make it better—especially on mobile screens—is adding a little bit of padding on the body element to prevent the card from looking cramped.

  1