Qr code component

Hello @Ghosk04!

Your solution looks great!

I have a suggestion for improvement:

• Use <main> to wrap the main content instead of <div>.

📌 Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page.

This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

I hope it helps!

Other than that, great job!

Hey Ghosk04. I can see that you've put a lot of effort and dedication into this. I'd like to offer some constructive feedback that may enhance the overall structure and functionality of your work. It seems the project relies heavily on generic <div> tags rather than utilizing semantic HTML elements such as <main>, <nav>, and <footer>. Incorporating these elements can significantly improve the document's structure, making it more accessible and easier to understand. For example, the <div.main> could be replaced with a <main> tag, while the <div.attribute> could be replaced with a <footer> tag.

Also, to position your "<div.big-box>," I would suggest:

height: 100vh; justify-content: center; align-items: center; max-width: 375px (the recommended width by the design)

I believe these adjustments will benefit your future projects and also contribute to their overall accessibility and maintainability.

I hope I was of help.

Well done for completing this challenge. HAPPY CODING