QR code component - Working with basic HTML and CSS

Community feedback

• 

  T

  Grace•31,090

  @grace-snowPosted over 1 year ago

  There's a few important changes needed on this

  1. height 100vh should be min-height. You never want to limit height of container elements (including body)
  2. similar, the card must not have a height either. It does not need a min height
  3. the width on the card should be a max-width and should be in rem
  4. font size must never ever be in px. Use rem. I've written a post about this

  One more point is more of a recommendation - the alt text on the image should really say where the QR code is going to. QR code to... Where

  Marked as helpful

  1

  ---

  

  Josh•100

  @Joshua-FarrPosted over 1 year ago

  Thanks so much for your feedback @grace-snow, I've implemented the changes as suggested.

  Follow-up question for you: Should margins/padding be expressed in rem as well? Or is it better to use px instead?

  0