Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR_Code page using CSS grid

Handyywebβ€’ 120

@HandyyWeb

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello, so it was my first challenge and I have a few questions :

How can I reduce the top gap between the image and te <div> box ? What was the font-family used for the text ? What is the different methods to center a div ( I have used margin for this challenge) ?

If you have any advice, will be happy to receive it ! Thank you

Community feedback

@MelvinAguilar

Posted

Hello there πŸ‘‹. Good job on completing the challenge !

I have some feedback for you if you want to improve your code.

HTML πŸ“„:

  • Use the <main> tag to wrap all the main content of the page instead of the <div class="first-box"> tag. With this semantic element you can improve the accessibility of your page.

Alt text πŸ“·:

  • The alt attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a better alt attribute would be QR code to frontendmentor.io

    If you want to learn more about the alt attribute, you can read this article. πŸ“˜.

CSS 🎨:

  • *What was the font-family used for the text ? * - r/ Outfit
  • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here πŸ“˜.
  • To center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here πŸ“˜.
body {
    min-height: 100vh;
    background-color: rgb(184, 183, 183);
    display: grid;
    place-content: center;
}
.first-box {
    /* margin-top: 100px; */
    /* margin-left: 535px; */
    /* padding-top: -40px; */
    /* padding-left: 5px; */
    /* padding-right: 5px; */
    padding: 5px;
    max-width: 14em;
    min-height: 24em;
    background-color: aliceblue;
    display: grid;
    /* place-items: center; */
    text-align: center;
    border: 1px solid rgba(111, 111, 111, 0);
    border-radius: 10px;
}

I hope you find it useful! πŸ˜„ Above all, the solution you submitted is great!

Happy coding!

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord