QR code component

Community feedback

• 

  mubizzy•1,520

  @mubizzyPosted over 2 years ago

  Excellent job on this challenge! your report has a few issues though:

  1. wrap everything in your body in <main> or use semantics

  2.   it is a best practice to use both HTML 5 and ARIA landmarks to ensure all     content is contained within a navigational region.

  Hope it helps:)...don't forget to mark it as helpful 👍

  You can get more details here...click here

  Marked as helpful

  0
• 

  Jo•110

  @joana-trotsPosted over 2 years ago

  Nice work! Just noticed small fixes you can do: "--h-font" and "--p-font" are the same, so you can delete one. And if you use variables for font-family, then you can do it for colors too ;) Also instead of "padding: 10px 15px 15px 15px;" you can use "padding: 10px 15px 15px;" (top, left&right, bottom). Good job, keep it up 👍

  2