@haquanq
Posted
Hello @therealalexolthoff 👋 👋 👋
Congrats on completing your first challenge, here is my feedback for you:
- Most of the time for styling it would be best to use class. Simply if you use an unique id on one element, the other should not have it and it is painful to remember which element did i/you used this id because i/you can't use it here (browsers still render it, you can still style same multiple id) to bind my JavaScript to element with such
id
. - About CSS you can check out some of my beginner solution on my GitHub repo
- The lowest hanging fruit of web accessibility is using semantic HTML markup at the right place and only using
div
for styling purpose (ex: you want to group related content like a heading or paragraph and style it in different ways on different screen size from vertical to horizontal or if the content stay the same don't wrap it), keep your HTML as simple as possible.
Hope this help 👽👽👽
Marked as helpful
@haquanq Thank you so much! I went ahead and switched to semantic markup even though it felt a bit weird. I also used classes as recommended, and I checked out your version: I see you used a lot of CSS variables, which makes sense. I am going to set up a few at a later point, right now I want to move to something new, but I really appreciate the feedback and I am glad I checked your version out.