Design comparison
Solution retrospective
I think it's a somewhat clean tailwindcss solution, I did use arbitrary values only once (for the width of the component).
What would I do better
I also did not take the time (for now) to add linting or automated code-formatting. It's a small project so I think it's ok but I know there are certain rules on how to
What challenges did you encounter, and how did you overcome them?I actually had trouble opening the figma design since there is not figma app for linux, so you have to use the web-interface and it took me a couple of minutes to find the import function.
What specific areas of your project would you like help with?- There is no actual css to review (the
input.css
contains only the tailwind directives), the whole code is in theindex.html
file and in thetailwind.config.js
- Is this actually "good" tailwindcss?
- Did I make good use of the semantic HTML elements
- I used an arbitrary value for the size of the QR code component ( the
w-[320px]
) and I set the with of the QR code image to 100% which then results in the 288px size of the image like in the figma/design. Is there maybe a better approach?
Community feedback
- @Alex-Archer-IPosted 4 months ago
Hi there!
Actually it is possible to review your css via the dev console =)
You did right thing with
img
by setting it's width to 100%, but as for card it's better to setmax-width
for it instead the hardcode one. Maybe it is no so important here (I doubt that screens less than 320px is a big thing, unless we talking about Apple Watch), but it is good practice in general.Almost that could be said about
height
of thebody
tag. Usemin-height
instead. It'll prevent overflow if the content will be larger than the screen.And yeah, you used correct semantic tags, but I can suggest you to reduce them a bit =) For such simple project you can get rid of the
section
anddiv
, and usemain
tag as a container withimg
,h2
(orh1
) andp
.Also you are already turn
main
tag in the flex, so you can usegap
property to create spaces between inner elements. It's a bit easier than with margins (but can create only equal spaces).So, congrats with your first challenge, you did great =)
Good luck and feel free to ask anything if need (I love parentheses too, by the by)
Marked as helpful1@vstmPosted 4 months ago@Alex-Archer-I Thank you for you thorough review, that's exactly what I was looking for, and I learned so much!
- Using
max-width
/min-height
is a good point, I can see how those are in general better than the "absolute"width
/height
properties. - Regarding the semantic tags I agree, I just got rid of all the div's but yeah in retrospect I used semantic tags where the element was actually only used for display purposes and did not have
- Yes I should have used the
gap
property, I think I was adding theflex
class after thespacing-*
tailwindcss class and it looked fine so I did not change anything else. For any future tailwindcss uses I need to remember that if I add aflex
orgrid
class to any element I should also change thespacing-*
classes togap-*
classes.
Thank you again (and yeah parentheses are the best :D)
1@Alex-Archer-IPosted 4 months ago@vstm
Really glad I could help =)
Also you can use
max-width
alongside with thewidth
.main { width: 95%; max-width: 75rem; }
That way
main
element became 95% if it's parents (or screen size, depends of context) will shrink less than 45rem.Sorry that I'm not using tailwind for examples, I'm not in deep touch with it (I prefer plain css + postcss plugins).
And just in case if you get e wrong, I don't meant that you should use less semantic tags. Just less tags in general =) Semantic tags in most cases are preferable. Again, you used them correct =)
0 - Using
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord