QR Code Component with Tailwind CSS

Community feedback

• 

  raya•2,870

  @rayaattaPosted 10 months ago

  Hello 👋Adam Turner, congratulations on completing this challenge 🎉

  I have some suggestions you might find useful.

  1 I noticed

  <article
  class="w-card px-4 pb-10 pt-4 bg-secondary-white drop-shadow-card rounded-card">
  

  In your html. Since the card is the only content of the page.a better element to use would be the <main> element. Replace the article with

  <main class="w-card px-4 pb-10 pt-4 bg-secondary-white drop-shadow-card rounded-card">
  

  2 I also noticed

  <h2 class="text-primary-dark-navy text-title text-center font-bold leading-title">
  

  since it is the only heading in the document you should replace it with <h1>.

  Here's a quick guide on how to use them:

  The <h1> to <h6> tags are used to define HTML headings. <h1> defines the most important heading. <h6> defines the least important heading. Only use one <h1> per page - this should represent the main heading/subject for the whole page. Also, do not skip heading levels - start with <h1>, then use <h2>, and so on. You can then style them in you css.

  Unlike what most people think, it's not just about the size and weight of the text It is about maintaining a clear and consistent hierarchy through out the document

  4 The qr code's alt attribute should not just have info that it is a qr code rather it should state where the qr leads i.e alt="qr code leading to frontendmentor.io

  I hope this helps 🙃 Your solution looks awesome Happy coding ✌️

  Marked as helpful

  0

  ---

  

  P

  Adam Turner•270

  @adamrichardturnerPosted 10 months ago

  @rayaatta Amazing, thank you for the feedback!

  I've implemented all the accessibility and structure enhancements suggested and the report is now clear.

  Thank you, really appreciate the informative advice :)

  0

  

  raya•2,870

  @rayaattaPosted 10 months ago

  I'm happy to help@adamrichardturner

  0