QR code component with tailwind css

Community feedback

• 

  Daniil Churikov•80

  @ddosiaPosted 16 days ago

  Hey. I am a newbiew, so take my feedback with a grant of salt.

  1. Both header and description font doesn't match to style guides: slate-500/900 but rather gray-600/900, thickness and line-height is different. Although I am not 100% sure how to choose the right line height and thickness based on the design pictures nor on figma.
  2. You are specifying these colors directly, which might be ok to complete the challenge but for the real usage I can imagine it can present a problem if later color choices would be changed. I've defined my colors in the tailwind.config.js and used them further, so now if something needed to be adjusted there is one place it needs to be done.
  3. padding from the bottom should be bigger and padding from the rest of the sides - smaller.
  4. I like how you specified the size of the container and then put w-full on the image itself, this is something I should have done. I've tried to get the right size of the image based on the figma, and 18rem is something I came to.

  0