QR code component with sass

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted over 2 years ago

  👾Hello Marina, congratulations for you really good solution!

  You've done pretty much anything this challenges requires. The tips I have for are really tiny details, the overall solution is almost 100%. Its responsive and the elements works good.

  Here's the tips:

  1.To clean a bit your code, you don't need a the <img> inside a <div> you can just delete this div, the image works alone inside the main container, this way you clean a bit your html.

  2.Use rem over px to have a better performance in difference screen sizes.

  3.Pay attention to the solution's report panel, you'll learn a lots about semantics and accessibility looking and fixing the error this panel gives you.

  Congrats, happy coding!

  0